Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds CardVerificationCodeElement #14

Merged
merged 2 commits into from
Dec 7, 2022
Merged

feat: Adds CardVerificationCodeElement #14

merged 2 commits into from
Dec 7, 2022

Conversation

dhudec
Copy link
Contributor

@dhudec dhudec commented Dec 5, 2022

Description

  • Adds CardVerificationCodeElement with fixed 3 digit length mask. Planning to add dynamic masking capabilities based on card brand with a future PR.

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@dhudec dhudec marked this pull request as ready for review December 5, 2022 19:51
@dhudec dhudec requested a review from a team as a code owner December 5, 2022 19:51
kevinperaza
kevinperaza reviewed Dec 6, 2022
View reviewed changes
lib/src/main/java/com/basistheory/android/view/CardVerificationCodeElement.kt
Comment on lines +5 to +6
import com.basistheory.android.view.transform.regexReplaceElementTransform
import com.basistheory.android.view.validation.luhnValidator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we're using these 2 on this file(?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this cleaned up in the next PR, and I have a goal to circle back and set up linting/formatting.

@dhudec dhudec merged commit f90e028 into master Dec 7, 2022
@dhudec dhudec deleted the eng-3888 branch December 7, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinperaza kevinperaza kevinperaza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhudec @kevinperaza