Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"scalable" icons directory should only be used for scalable (vector) image formats #138

Open
audreytoskin opened this issue Sep 30, 2020 · 1 comment

Comments

@audreytoskin
Copy link
Contributor

audreytoskin commented Sep 30, 2020

A minor issue, but I think this mismatch might be affecting how Lector appears in the "app stores" for the distros where it's been packaged...

By default on Linux, Lector installs its Lector.png icon under /usr/share/icons/hicolor/scalable/apps/. However, That "scalable" subdirectory is supposed to only be used for scalable (vector) image formats -- on my system, basically every other image in that directory is an SVG, not a PNG.

Since, Lector.png is a 512×512-pixel raster image, I think it should get installed to /usr/share/icons/hicolor/512x512/apps/ instead. (The downside here being if you replaced it with a larger image, you would need to move it to the the matching directory.)

Or, you could use the scalable directory if you had an SVG version of the Lector icon.

@audreytoskin
Copy link
Contributor Author

...Or maybe it would be better to use ./lector/resources/raw/logo/icon.svg instead? It's a nicer-looking image, and is also newer by about a year, so I suddenly wonder if ./lector/resources/raw/Lector.png is just leftovers from an older design that otherwise isn't used anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant