-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and define "base" and "general" #1640
Comments
Yes, good stuff! A lot of this is there for historic reasons and needs to be cleaned up, moved, or refactored. The Cleaning it up would be good, but would require some documentation or notification. Release notes would be nice for these kind of changes. |
Good question (and sorry for the delay in getting back to you!) I think we shouldn't remove the function, since it looks useful and we don't know how many people are using it... Having said that, the implementation is more complex than needed, the same thing could have been achieved with an alias. The optional parameter handling is not really needed, and switching between Linux/macOS could have been done when defining the alias. This might be a candidate for moving it to an alias. Renaming is probably a better choice, although if people are using the function, they might be confused if it's suddenly gone. Not sure what to do in this case. |
Yeah, I thought about this for a while. Overarching $0.02; when I tell devs that I have no influence over to use bash-it, I get an earful about performance. Especially with MacOS pushing zsh, we will need to do a look at performance and that, IMHO, will necessitate organization so useless functions are not loaded. I've even been reading about dynamic built-ins and what that could look like for the backbone of bash-it. I'd say let's move these functions that don't have clear ownership or hierarchy ( Edit: yeah I also like the idea of renaming, because that would free the namespace for maintained functions. although, in this case, usage is way too general for me to sign off on a name like that these days. |
@cornfeedhobo wanna follow up on that? |
@NoahGorny I was waiting for more opinions. I'd like to rename or remove some of these functions, and we haven't really discussed how we want to handle that. |
I'd like to suggest:
In any case, I definitely vote for more smaller files so that users can load things that work for them, and not "general" with some random stuff that may or may not be useful for them. No idea what to do about backwards compatibility; might be more complexity than it's worth. |
We have
base.plugin.bash
andgeneral.aliases.bash
base
seems like it should only own things used by other components, right?general
should be non-specific, all around general stuff, right?Some of the stuff included can be pretty random. e.g. the alias includes support for
pianobar (without checking for it's existence). Things like pianobar are easy to identify and break out into dedicated plugins, but more contentious to tackle are things like where to place:
ls
(without checking or negating the existing alias)irc
aliasSo I'm going to start some PRs, but I'd also like to start a discussion and collect opinions.
The text was updated successfully, but these errors were encountered: