Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mget to get apps installed count / reviews instead of loop - Dont loop in infra #1353

Closed
beastoin opened this issue Nov 18, 2024 · 7 comments
Assignees

Comments

@beastoin
Copy link
Collaborator

beastoin commented Nov 18, 2024

Redis rps is ~ 400/s now and would keep increasing to indefinitely base on the number of apps.

dont loop in infra

use mget

Image

Image

@beastoin beastoin converted this from a draft issue Nov 18, 2024
@beastoin beastoin changed the title Use mget to get apps installed count / reviews instead of loop - Dont loop to infra Use mget to get apps installed count / reviews instead of loop - Dont loop in infra Nov 18, 2024
@beastoin
Copy link
Collaborator Author

@nquang29 let's see if you're still remember basic techniques 🌚

@beastoin
Copy link
Collaborator Author

context: we are facing with 1/ high p99 latency with api /apps 2/ high costs due to too many tracing spans in Datadog

pls help me resolve these 😌

thank you!

@nquang29
Copy link
Collaborator

@nquang29 let's see if you're still remember basic techniques 🌚

let me see

@nquang29
Copy link
Collaborator

@beastoin
Copy link
Collaborator Author

ops change logs

  1. feature on prod 🚀

@nquang29 fyi ~

@github-project-automation github-project-automation bot moved this from In review to Done in omi TODO Nov 23, 2024
@beastoin
Copy link
Collaborator Author

before | after
Image

saving x10

@beastoin
Copy link
Collaborator Author

anw dont forget leave a check at the mget limits, e.g. what is the maximum keys / request ? @nquang29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants