Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion about the canonicalization. #15

Open
hoyeYang opened this issue Nov 13, 2024 · 0 comments
Open

Confusion about the canonicalization. #15

hoyeYang opened this issue Nov 13, 2024 · 0 comments

Comments

@hoyeYang
Copy link

Great work! But I'm confused about these lines

rot2d[..., :2] = 0
if self.offset:
# add a bit more rotation
rot2d[..., 2] += torch.pi/2

Assuming the original rot2d is $(x\theta, y\theta, z\theta)$, directly transforming the rot2d represented by axis-angle into $(0, 0, z\theta+\frac{\pi}{2})$ seems confusing.

If the canonicalization is removed, will the experimental results be significantly affected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant