Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeRequest function receives a body even for GET requests (and DELETE as well) #520

Open
mutedchaos opened this issue Feb 11, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mutedchaos
Copy link
Contributor

mutedchaos commented Feb 11, 2021

The makeRequest method is passed an empty object as a body even when the API is a method that does not support one, which potentially unnecessary complication to the implementing logic as libraries might reject a GET request with a body, and evidently AWS API gateway does as well.

This should be pretty safe to change for GET requests, DELETE is more problematic as although it is not supposed to have a body, it is not entirely unusual for people to intentionally make DELETE requests with a body. Maybe there should be some compatibility options for this...?

At the very least the existing behaviour should be documented.

@mutedchaos mutedchaos added the enhancement New feature or request label Feb 11, 2021
@mutedchaos mutedchaos self-assigned this Mar 20, 2021
@mutedchaos mutedchaos added this to the 2.0.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant