You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The makeRequest method is passed an empty object as a body even when the API is a method that does not support one, which potentially unnecessary complication to the implementing logic as libraries might reject a GET request with a body, and evidently AWS API gateway does as well.
This should be pretty safe to change for GET requests, DELETE is more problematic as although it is not supposed to have a body, it is not entirely unusual for people to intentionally make DELETE requests with a body. Maybe there should be some compatibility options for this...?
At the very least the existing behaviour should be documented.
The text was updated successfully, but these errors were encountered:
The makeRequest method is passed an empty object as a body even when the API is a method that does not support one, which potentially unnecessary complication to the implementing logic as libraries might reject a GET request with a body, and evidently AWS API gateway does as well.
This should be pretty safe to change for GET requests, DELETE is more problematic as although it is not supposed to have a body, it is not entirely unusual for people to intentionally make DELETE requests with a body. Maybe there should be some compatibility options for this...?
At the very least the existing behaviour should be documented.
The text was updated successfully, but these errors were encountered: