Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware should be applied to unimplemented APIs #289

Open
mutedchaos opened this issue Mar 29, 2020 · 0 comments
Open

Middleware should be applied to unimplemented APIs #289

mutedchaos opened this issue Mar 29, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mutedchaos
Copy link
Contributor

With autoImplementAllAPIs enabled, middleware should apply even if the route has not yet been implemented. At this time the middleware is not applied. While such routes do nothing useful, lack of the support can prevent requests from being logged, cors headers being applied (leaving browsers unaware of lack of implementation) and so on.

While it might be convenient even without autoImplementAllAPIs, because of the reliance on express routing without it, implementing it is not viable or really sensible anyway.

@mutedchaos mutedchaos added the enhancement New feature or request label Mar 29, 2020
@mutedchaos mutedchaos self-assigned this Mar 20, 2021
@mutedchaos mutedchaos added this to the 2.0.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant