Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Pull/Merge Approval Flow #4

Open
1 task
abbadon1334 opened this issue Nov 20, 2020 · 4 comments
Open
1 task

Pull/Merge Approval Flow #4

abbadon1334 opened this issue Nov 20, 2020 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@abbadon1334
Copy link
Member

  • Activated branch protection for dev/main to avoid, independent push and merge.

  • At least 2 reviewers need to approve the PR before merging.

  • To review and approve the PR quickly and only from a conceptual point of view and don't lose time doing local functional testing, we need to add branches protection with UnitTest.

Anyone can auto-assign this task and transform this issue into a PR.

@kasuken is the only one who can bypass this restriction to avoid live coding problem, it's already too good in chaos creation.

@abbadon1334 abbadon1334 added the help wanted Extra attention is needed label Nov 20, 2020
@binick
Copy link

binick commented Nov 27, 2020

Hi @abbadon1334, do you have a preference about:

  • which build system?
  • unit testing libraries your want to use?

If your want integrate CI/CD practices this issues can be related to #10.

@abbadon1334
Copy link
Member Author

Hi @abbadon1334, do you have a preference about:

  • which build system?
  • unit testing libraries your want to use?

If your want integrate CI/CD practices this issues can be related to #10.

Part of those tasks was assigned during live to @paranoiasystem, you can reach us and @paranoiasystem joining discord

@Morati81
Copy link

Hi @abbadon1334 ,

this is something that only repo owner or someone with admin permission can do.

see here https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuring-protected-branches as a reference.

@abbadon1334
Copy link
Member Author

Hi @abbadon1334 ,

this is something that only repo owner or someone with admin permission can do.

see here https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuring-protected-branches as a reference.
Hi @Morati81
thanks for the link! we have already done that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants