feat: add GD image backend #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage ? 64.93%
Complexity ? 981
=======================================
Files ? 48
Lines ? 3094
Branches ? 0
=======================================
Hits ? 2009
Misses ? 1085
Partials ? 0 ☔ View full report in Codecov by Sentry. |
DASPRiD
requested changes
Mar 19, 2024
README.md
Outdated
| @@ -37,3 +37,21 @@ BaconQrCode comes with multiple back ends for rendering images. Currently includ | |||
| - `ImagickImageBackEnd`: renders raster images using the Imagick library | |||
| - `SvgImageBackEnd`: renders SVG files using XMLWriter | |||
| - `EpsImageBackEnd`: renders EPS files | |||
|
|
|||
| ### GDLib Renderer | |||
| GD library has so many limitations, that GD support is not added as backend, but as separated rendered. | |||
README.md
Outdated
|
|
||
| ### GDLib Renderer | ||
| GD library has so many limitations, that GD support is not added as backend, but as separated rendered. | ||
| Use `GDLibRendered` instead of `ImageRenderer`. Here are limitations: |
There was a problem hiding this comment.
Oh, and: "These are the limitations" :)
src/Renderer/GDLibRenderer.php
Outdated
|
|
||
| private function imageFilledPolygon(array $points, int $color): bool | ||
| { | ||
| if (\PHP_VERSION_ID >= 80000) { |
There was a problem hiding this comment.
This check should not be required anymore, as we raised the minimum version to 8.1 in the next release.
arxeiss
force-pushed
the
add-gd-backend-php8.1
branch
from
2723a0e to
615d1f3
Compare
DASPRiD
approved these changes
Mar 19, 2024
|
LGTM, thanks for your work! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of closed #114
My client's web hosting provider sucks, and they don't have support for Imagick, even though they are promising it will be added.
I'm generating QR codes for payment, which is added into email body. And email client's do not have nice support for SVG. So I need old-school GD support.
However, GD has limited sets of functions. I believe, that it is OK, when that Renderer will have also limited sets of features.
So this is not supported:
And because GD does not support Paths like Imagick or SVG do, I need to generate a bit different paths, so they are not so complex.
Sorry for opening new PR, but I had to change branch. I really needed the GD Renderer and in many projects I'm using this in
package.json. Not to break them by changing commit name, I had to create new branch. But then it is not possible to change source branch in PR.