New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to stream buffers via res.send() #26

Closed

gavoja opened this issue Apr 3, 2019 · 1 comment

gavoja commented Apr 3, 2019

The data check in response-extensions.js is too weak. When using res.send() with a buffer, it converts the response to JSON.

  if (typeof data === 'object') { // Buffers should be excluded.
    // transparently setting the 'content-type' header if JSON
    res.setHeader('content-type', 'application/json')
    params.data = JSON.stringify(params.data)
  }

The text was updated successfully, but these errors were encountered:

Collaborator

jkyberneees commented Apr 4, 2019

Hi @gavoja thanks for sharing your issue.
The issue was fixed on v2.11.0 https://github.com/jkyberneees/ana/releases/tag/v2.11.0

Regards

jkyberneees closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment