Tailor 0.11.1 support #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am currently auditing an app which unfortunately has no unit tests. `run-sonar-swift.sh` expected to have unit tests and thus did not work with this project. This patch adds a command line option to tell the script that there is no unit tests: `run-sonar-swift.sh -nounittests`.
Allow the de-activation of unit tests execution and coverage
Add tailor model for SQALE.
Add description for tailor to README.md
Add screenshot for changing the used Linter.
Update Features Table.
|
Thanks a lot for this contribution ! |
Closed
|
OK, |
|
Thanks again @tzwickl ! It is merged on develop. The only thing I changed : I removed Tailor rules from the default 'Swift' profile as many rules are redundant with SwiftLint (and kept SwiftLint rules, as there are more rules at the time). Gilles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extended your PlugIn to support an additional Linter called Tailor for cross-platform support. We are using SonarQube at the university but only have Unix Servers available and as we started now developing an iOS App and didn't want to spend much money on the commercial Swift PlugIn for SonarQube we found your tool and decided to use it for our purposes. But we found out that the Linter (SwiftLint) you were using for Issue creation only works on MacOS which wasn't an option for us so we extended your tool to support the cross-platform static analysis and lint tool Tailor. We don't need any unit tests as we have Bamboo with iOS integration so we can build the app and run all the tests. The only missing thing for us was now to have some framework for analyzing our Code Quality. We extended the plugin without interfering with your existing functionalities, so everything works as before, but now you can select an additional Quality Profile in SonarQube which is Tailor. The Linter (Tailor) will only be executed if installed and will only show up in SonarQube if the Tailor Quality Profile was selected otherwise the SwiftLint Profile is used. If you like our changes you can integrate them so other people might profit from them as well :)