fix: location of the test source file #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelfoppolo
requested changes
Aug 22, 2019
swiftlang/src/main/java/com/backelite/sonarqube/swift/surefire/SwiftTestFileFinder.java
Outdated
Show resolved
Hide resolved
davidy4ng
force-pushed
the
fix/unable-to-locate-test-files
branch
from
3c47175 to
60541fd
Compare
gaelfoppolo
approved these changes
Aug 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin may not be able to find the test source files, which ends up in having a sonarqube report without any tests.
This may occurs because the JUnit report replaces
-,+or_.Since we can't get the full path name from the "classname" attribute in the JUnit report, the fix fallback by searching any file matching the classname in the whole sonar.tests directory.
Notice: It's bad practice to have spaces or symbols in your paths, directory or file name.