Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BKTPopinAlignementOption typos #17

Open
diegorozen opened this issue Apr 29, 2014 · 1 comment
Open

BKTPopinAlignementOption typos #17

diegorozen opened this issue Apr 29, 2014 · 1 comment

Comments

@diegorozen
Copy link

BKTPopinAlignementOption enum and its constants should be 'Alignment' (without the extra 'e')
@sparga
Copy link
Collaborator

sparga commented Apr 30, 2014

You are right. I fixed the typo in the method name but I missed this one...
Unfortunately, I can't change it without breaking compatibility.
As MaryPopin follows semantic versioning, such a change would require a major version number change. But I keep the issue open for the next major release.

@sparga sparga mentioned this issue May 5, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diegorozen @sparga