Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max2Babylon - Alpha Coverage could use Cutout in Physical Material #860

Open
echadwick-artist opened this issue Jul 24, 2020 · 4 comments
Open

Comments

@echadwick-artist
Copy link

I'd like to propose an alternative material setup for Alpha Coverage.

Max2Babylon currently uses the Transparency Weight in a Physical material to specify Alpha Coverage as a value or texture. This is incorrect for three reasons:

  1. Transparency Weight uses values (white is clear, black is opaque) that are the inverse of the glTF standard for Alpha Coverage (white is opaque, black is clear).
  2. Most pre-existing assets use the glTF standard. These assets must be manually inverted prior to use with Max2Babylon.
  3. Alpha Coverage makes a surface fully transparent, while Transparency Weight in 3ds Max is more like glass as it preserves reflections etc.

I propose to use the Cutout input, as this solves all three issues. To supply a value instead of a texture, the user could connect an Output node and use the Output Amount spinner.

Transparency Weight could still be supported for legacy content, but the Cutout would be preferred as the new method. If both Transparency Weight and Cutout were present in the same model, Cutout would take precedence.

An example model to test with:
2020-07-24 10_16_19-Slate Material Editor

PhysicalMaterial_Cutout.zip

Texture is from the example model https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/AlphaBlendModeTest

What do you think?

@Drigax
Copy link
Contributor

Drigax commented Aug 11, 2020

Ah, cool proposal, I agree that we don't want to remove previous support for transparency map, but adding support for the cutout map as an input seems to be more intuitive.

@deltakosh
Copy link
Contributor

@echadwick-wayfair fancy doing a PR? :)

@echadwick-artist
Copy link
Author

Ha. I'm not a coder. I can muck around in text files here and there, but can't code my way out of a wet paper bag.

@deltakosh
Copy link
Contributor

Ok I keep it open with help wanted if the community wants to help :)

@thomlucc thomlucc added this to the 5.0 milestone Dec 2, 2020
@thomlucc thomlucc removed this from the 5.0 milestone Feb 11, 2021
@thomlucc thomlucc added this to the 5.0 milestone Feb 26, 2021
@thomlucc thomlucc modified the milestones: 6.0, Future Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants