Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules do not init by default when first cloning the repository #4

Open
frozenfrank opened this issue Sep 18, 2024 · 0 comments
Open

Comments

@frozenfrank
Copy link
Contributor

frozenfrank commented Sep 18, 2024

Overview

The example demonstrated in this repo with the submodule organization is incompatible with the build commands for the phase. Introducing submodules into the project create complexities in the cloning process that are not accounted for in the standard grading procedure.

The course example and the instructions need to be reconciled to be compatible with each other; alternatively, the instructions should be make more clear that the grader will load submodules as necessary.

One potential solution is to just copy the file into the project without dealing with the complexities of submodules.

Discussion

Specifically, in the Phase 2 Submission instructions-,Submission%3A%20Git,-You%E2%80%99ll%20submit%20your), the following command sequence is given:

git clone <yournetid>@homework.rc.byu.edu:scicomp
cd scicomp
git checkout phase2
module load gcc/14.1 cmake catch2
mkdir bld
cd bld
cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo ..
cmake --build . --parallel

The first command git clone will not download content of the submodules properly (it only creates an empty directory). In the documentation, there is a --recurse-submodules flag that should do the trick. When I tried the command, I got an error potentially related to public key permissions?

Screenshots

  1. Simply cloning the project results in no content for the required subdirectories.
image
  1. Recursively cloning the project runs into a permission issue when loading the submodule.
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant