Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing an unrecognized option should result in an error (but doesn't) #89

Open
yfarjoun opened this issue Mar 16, 2023 · 4 comments · Fixed by #95
Open

Providing an unrecognized option should result in an error (but doesn't) #89

yfarjoun opened this issue Mar 16, 2023 · 4 comments · Fixed by #95

Comments

@yfarjoun
Copy link
Contributor

yfarjoun commented Mar 16, 2023

I've been burned by this...

Currently, bustools will cheerfully ignore options that it doesn't recognize. The only effect will be one line in stderr but if it can run without that option it will do its best.

I had the wrong version of bustools (0.39.3) and I called it with --em and since it was in a pipeline and the exit code was 0, everything succeeded and I was looking at single-mapped counts thinking that they were multi_em counts....

I would like propose that if bustools finds an option it doesn't know what to do with, it would emit an error, and promptly exit with a non-zero exit-code.

Example with the latest version of bustools (0.42.0):

$ bustools count --emx -e translation.txt -t transcripts.txt --genecounts -o test output.sorted.bus
count: unrecognized option '--emx'
$ echo $?
0

(and the output files have been created...)

@yfarjoun
Copy link
Contributor Author

Any thoughts about this? I can try to submit a PR if the direction is acceptable.

@Yenaled
Copy link
Collaborator

Yenaled commented Jul 10, 2023

If you submit a PR, I can put it into the next release of BUStools (likely 0.43.1).

@yfarjoun
Copy link
Contributor Author

done.

@nh13
Copy link

nh13 commented Sep 15, 2023

I would welcome this! Helps the user not tie themselves in knots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants