Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add current exchange rate to wallet #35

Open
Pega88 opened this issue May 10, 2018 · 1 comment
Open

add current exchange rate to wallet #35

Pega88 opened this issue May 10, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@Pega88
Copy link
Contributor

Pega88 commented May 10, 2018

wondering if it would make sense to show FIAT and/or current BTC value of the BTCP held in the wallet.

@Pega88 Pega88 added the enhancement New feature or request label May 10, 2018
@fokep
Copy link

fokep commented Jul 8, 2018

For sure, that could be a nice feature! Maybe just make a background call to API on startup or on enable/change currency and display converted value in parenthesis behind balances with $CURRENCY like

0.00 BTCP (0.00 $CURRENCY)

Here's the CMC API link to fetch BTCP/USD:

https://api.coinmarketcap.com/v2/ticker/2575/ where the response is in

[data][quotes][USD][price]

To fetch other currency it's

https://api.coinmarketcap.com/v2/ticker/2575/?convert=$CURRENCY and response is in

[data][quotes][$CURRENCY][price]

Not sure if should be enabled by default, to prevent info leak to 3rd party (API call). Maybe a little submenu

Currency Conversion

  • Enable (yes/default no)
  • Settings
    -- USD
    -- Other
    --- Fiat
    --- Cryptocurrency
  • Refresh #Instead of making intermittent calls to API

Fiat currency list: "AUD", "BRL", "CAD", "CHF", "CLP", "CNY", "CZK", "DKK", "EUR", "GBP", "HKD", "HUF", "IDR", "ILS", "INR", "JPY", "KRW", "MXN", "MYR", "NOK", "NZD", "PHP", "PKR", "PLN", "RUB", "SEK", "SGD", "THB", "TRY", "TWD", "ZAR"

Cryptocurrency list: "BTC", "ETH" "XRP", "LTC", and "BCH"

Anyone volunteering to implement? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants