Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blake3.c:354:22: error: logical ‘and’ of mutually exclusive tests is always false [-Werror=logical-op] #379

Closed
divinity76 opened this issue Jan 29, 2024 · 0 comments

Comments

@divinity76
Copy link
Contributor

divinity76 commented Jan 29, 2024

any suggestions on fixing this?

/bin/bash /home/travis/build/php/php-src/libtool --silent --preserve-dup-deps --tag=CC --mode=compile gcc -Iext/hash/ -I/home/travis/build/php/php-src/ext/hash/ -I/home/travis/build/php/php-src/include -I/home/travis/build/php/php-src/main -I/home/travis/build/php/php-src -I/home/travis/build/php/php-src/ext/date/lib -I/usr/include/libxml2 -I/usr/include/s390x-linux-gnu -I/usr/include/enchant -I/usr/include/glib-2.0 -I/usr/lib/s390x-linux-gnu/glib-2.0/include -I/usr/include/libpng16 -I/usr/include/freetype2 -I/home/travis/build/php/php-src/ext/mbstring/libmbfl -I/home/travis/build/php/php-src/ext/mbstring/libmbfl/mbfl -I/usr/include/postgresql -I/usr/include/tidy -I/home/travis/build/php/php-src/TSRM -I/home/travis/build/php/php-src/Zend  -D_GNU_SOURCE -D_REENTRANT -pthread  -fno-common -Wformat-truncation -Wlogical-op -Wduplicated-cond -Wno-clobbered -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -g -fvisibility=hidden -pthread -O0 -Wimplicit-fallthrough=1 -DZTS -DZEND_SIGNALS -DZEND_MAX_EXECUTION_TIMERS -Werror    -DBLAKE3_USE_NEON=0 -c /home/travis/build/php/php-src/ext/hash/blake3/upstream_blake3/c/blake3.c -o ext/hash/blake3/upstream_blake3/c/blake3.lo  -MMD -MF ext/hash/blake3/upstream_blake3/c/blake3.dep -MT ext/hash/blake3/upstream_blake3/c/blake3.lo

/home/travis/build/php/php-src/ext/hash/blake3/upstream_blake3/c/blake3.c: In function ‘compress_subtree_to_parent_node’:

/home/travis/build/php/php-src/ext/hash/blake3/upstream_blake3/c/blake3.c:354:22: error: logical ‘and’ of mutually exclusive tests is always false [-Werror=logical-op]

  354 |   while (num_cvs > 2 && num_cvs <= MAX_SIMD_DEGREE_OR_2) {

      |                      ^~

cc1: all warnings being treated as errors

make: *** [Makefile:1910: ext/hash/blake3/upstream_blake3/c/blake3.lo] Error 1

make: *** Waiting for unfinished jobs....

observed on 1.5.0, full compiler log https://app.travis-ci.com/github/php/php-src/builds/268584939 , source php/php-src#13194

divinity76 added a commit to divinity76/BLAKE3 that referenced this issue Jan 29, 2024
ref BLAKE3-team#379

/home/travis/build/php/php-src/ext/hash/blake3/upstream_blake3/c/blake3.c: In function ‘compress_subtree_to_parent_node’:

/home/travis/build/php/php-src/ext/hash/blake3/upstream_blake3/c/blake3.c:354:22: error: logical ‘and’ of mutually exclusive tests is always false [-Werror=logical-op]

  354 |   while (num_cvs > 2 && num_cvs <= MAX_SIMD_DEGREE_OR_2) {

      |                      ^~

cc1: all warnings being treated as errors

make: *** [Makefile:1910: ext/hash/blake3/upstream_blake3/c/blake3.lo] Error 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant