You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here, momentum is being cast to a single GMat. However, momentum was defined as an array of GMats at the start of the code. Running ADAGrad with momentum will result in an error since an array can't be cast to a matrix. The fix is to change momentum to momentum(i) for both of these cases, which makes sense since this is in a loop around all the model matrices, and also, the CPU version uses momentum(i).
When I changed it to momentum(i), the GPU version of ADAGrad works correctly.
The text was updated successfully, but these errors were encountered:
Currently on the master branch, in the ADAGrad code (link to code), in lines 145 and 148, we have:
and
Here,
momentum
is being cast to a single GMat. However,momentum
was defined as an array of GMats at the start of the code. Running ADAGrad with momentum will result in an error since an array can't be cast to a matrix. The fix is to changemomentum
tomomentum(i)
for both of these cases, which makes sense since this is in a loop around all the model matrices, and also, the CPU version usesmomentum(i)
.When I changed it to
momentum(i)
, the GPU version of ADAGrad works correctly.The text was updated successfully, but these errors were encountered: