Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoMUpgrader causing long open times with certain scripts #83

Closed
enarhi opened this issue Jul 1, 2020 · 1 comment
Closed

BHoMUpgrader causing long open times with certain scripts #83

enarhi opened this issue Jul 1, 2020 · 1 comment
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@enarhi
Copy link
Member

enarhi commented Jul 1, 2020

Description:

When trying to open certain scripts, Grasshopper hangs for a while before finally opening the script. This appears to be caused by BHoMUpgrader as per below:
image

Steps to reproduce:

Open test script below. Grasshopper hangs and then takes significantly longer to open the script than it used to.

Expected behaviour:

Script opens as quickly as it was previously.

Test file(s):

LCA Per Revit Type Script

@enarhi enarhi added the type:bug Error or unexpected behaviour label Jul 1, 2020
@enarhi enarhi changed the title BHoMUpgrader causing freeze with certain scripts BHoMUpgrader causing long open times with certain scripts Jul 1, 2020
@FraserGreenroyd FraserGreenroyd removed their assignment Jul 1, 2020
@adecler
Copy link
Member

adecler commented Jun 2, 2021

This was fixed in BHoM/BHoM_Engine#2434.

With the version being saved in the serialised objects. Forward versioning will be a lot faster since it will only se the upgraders between the recorded version and the current version instead of all available upgraders.

@adecler adecler closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

4 participants