Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Load read/create bugs #219

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Fixing Load read/create bugs #219

merged 1 commit into from
Mar 19, 2021

Conversation

JosefTaylor
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #216
Closes #217
Closes #218

Fixed un-handled missing load types in Create and Read - create would crash, read would return every load in the model.
Fixed BarPointLoad, which assumed a relative distance, rather than absolute.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BuroHappoldEngineering/Create%20Read%20Loads?csf=1&web=1&e=RgtJKt

Changelog

Additional comments

@JosefTaylor JosefTaylor added the type:bug Error or unexpected behaviour label Mar 19, 2021
@JosefTaylor JosefTaylor added this to the BHoM 4.1 β Release milestone Mar 19, 2021
@JosefTaylor JosefTaylor self-assigned this Mar 19, 2021
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2021

@JosefTaylor to confirm, check-core task is now queued.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2021

@JosefTaylor to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2021

@JosefTaylor to confirm, check-versioning task is now queued.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2021

@JosefTaylor to confirm, check-installer task is now queued.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Mar 19, 2021
@FraserGreenroyd
Copy link
Contributor

As #217 is listed as a feature because it is implementing new functionality, this PR as a whole needs the feature tag, which also means it probably can't be merged till the end of sprint

enarhi
enarhi approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enarhi
Copy link
Member

enarhi commented Mar 19, 2021

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2021

@enarhi to confirm, the task for checking if this Pull Request is ready to merge is now queued.

@enarhi enarhi merged commit b3843a1 into master Mar 19, 2021
@enarhi enarhi deleted the SAP2000_Toolkit-#216-Load-bugfixes branch March 19, 2021 20:08
@enarhi enarhi mentioned this pull request Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enarhi enarhi enarhi approved these changes

@jeanlucjackson jeanlucjackson Awaiting requested review from jeanlucjackson

@maryannewachter maryannewachter Awaiting requested review from maryannewachter

Assignees

@JosefTaylor JosefTaylor

Labels
type:bug Error or unexpected behaviour type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 4.1 β Release
3 participants
@JosefTaylor @FraserGreenroyd @enarhi