Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected/unwanted type update in case of 2 types with same name #1519

Open
pawelbaran opened this issue Dec 13, 2024 · 0 comments
Open

Unexpected/unwanted type update in case of 2 types with same name #1519

pawelbaran opened this issue Dec 13, 2024 · 0 comments
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@pawelbaran
Copy link
Member

pawelbaran commented Dec 13, 2024

Description:

When updating elements via Revit adapter, type can be changed unexpectedly in case of multiple families containing types with name matching the type name of the updated element. That happens because on push/update Revit adapter attempts to update the type, and the default type picking mechanism is based on name of the property (the object returned by GetRevitElementType method), where the adapter picks first type that matches it.

I scratched my head a bit around that one, looks like the best solution will be adding family name prefix to the type name in name of the property on pull, i.e. after pulling, object returned by GetRevitElementType should have Name in the following format: {familyName}: {typeName} rather than {typeName} - that would eliminate the ambiguity.

Test files:

On SharePoint

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Dec 13, 2024
@pawelbaran pawelbaran self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

1 participant