Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification of results for structural adapters #180

Open
peterjamesnugent opened this issue Jan 20, 2021 · 3 comments
Open

Verification of results for structural adapters #180

peterjamesnugent opened this issue Jan 20, 2021 · 3 comments
Assignees
Labels
severity:critical No workaround exists. Essential to continue type:test-script Creation of unit test required

Comments

@peterjamesnugent
Copy link
Member

peterjamesnugent commented Jan 20, 2021

Definition of the test :

I've produced a script to create two (for now) simple models:

  • A simply supported beam,
  • A free standing column

A number of different loads are applied:

  • Bar uniformly distributed load
  • Shear Y and Shear Z applied at mid span
  • Torsion applied at free end
  • Axial force applied at free end

For this toolkit can you please run the script to create the model, analyse the model and verify that the results are pulled.

This is also a good opportunity to ensure the results follow the BHoM's Structural Conventions.

Please save your model in an appropriate folder in this location.

The script to push the generic models can be found here.

Also it should be noted that you will be required to reinitialise the AdapterId components (I've highlighted them in red) - see here for the issue: BHoM/BHoM_Adapter#283.

@peterjamesnugent peterjamesnugent added severity:critical No workaround exists. Essential to continue type:test-script Creation of unit test required labels Jan 20, 2021
@peterjamesnugent peterjamesnugent added this to the BHoM 4.1 β RC milestone Jan 20, 2021
@peterjamesnugent
Copy link
Member Author

It also worth noting that the models I have created are in SI Units - so unless this toolkit implements the Units_Engine it should also be in SI Units to allow easy comparison of results between calculated and expected values.

@JosefTaylor
Copy link
Contributor

@peterjamesnugent I changed the links as there was a typo in the folder name - you may need to fix links on other issues.

@peterjamesnugent
Copy link
Member Author

Thanks @JosefTaylor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:critical No workaround exists. Essential to continue type:test-script Creation of unit test required
Projects
None yet
Development

No branches or pull requests

4 participants