Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align RAM custom results to IResult, handle with ResultRequest #156

Open
JosefTaylor opened this issue Aug 11, 2020 · 0 comments
Open

Align RAM custom results to IResult, handle with ResultRequest #156

JosefTaylor opened this issue Aug 11, 2020 · 0 comments
Assignees
@enarhi
Labels
type:compliance Non-conforming to code guidelines

Comments

@JosefTaylor
Copy link
Contributor

Broken rules:

RAMFactoredEndReaction, and possibly RAMPointGravityLoad, and RAMLineGravityLoad, are results masquerading as IBHoMObjects.

Suggestions to restore compliance:

Refactor these objects as needed, test that ResultRequest can pull them out.
@JosefTaylor JosefTaylor added the type:compliance Non-conforming to code guidelines label Aug 11, 2020
@JosefTaylor JosefTaylor added this to the BHoM 3.3 β MVP milestone Aug 11, 2020
@JosefTaylor JosefTaylor mentioned this issue Aug 11, 2020
Closed
@enarhi enarhi removed this from the BHoM 3.3 β MVP milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enarhi enarhi

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enarhi @JosefTaylor