Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PowerPointAdapter to use ActionConfig #22

Open
Tom-Kingstone opened this issue Jul 4, 2024 · 0 comments
Open

Refactor PowerPointAdapter to use ActionConfig #22

Tom-Kingstone opened this issue Jul 4, 2024 · 0 comments
Assignees
Labels
type:compliance Non-conforming to code guidelines

Comments

@Tom-Kingstone
Copy link
Contributor

Broken rules:

As with other adapters, all actions should use an action config to determine the template and output files (see IES_Toolkit). This would allow an adapter to use different template/output files without re-instantiating the adapter with different parameters.

Suggestions to restore compliance:

Remove constructors that accept FileSettings and Stream inputs, and create ActionConfigs for these scenarios. Then modify existing actions to use the action configs instead of the private FileSettings/Stream properties. This would also make determining the actions to use (file settings vs stream usage).

This is by definition a breaking change, so versioning will be required, and ensure to update affected toolkits.

@Tom-Kingstone Tom-Kingstone added the type:compliance Non-conforming to code guidelines label Jul 4, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

No branches or pull requests

1 participant