You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As with other adapters, all actions should use an action config to determine the template and output files (see IES_Toolkit). This would allow an adapter to use different template/output files without re-instantiating the adapter with different parameters.
Suggestions to restore compliance:
Remove constructors that accept FileSettings and Stream inputs, and create ActionConfigs for these scenarios. Then modify existing actions to use the action configs instead of the private FileSettings/Stream properties. This would also make determining the actions to use (file settings vs stream usage).
This is by definition a breaking change, so versioning will be required, and ensure to update affected toolkits.
The text was updated successfully, but these errors were encountered:
Broken rules:
As with other adapters, all actions should use an action config to determine the template and output files (see IES_Toolkit). This would allow an adapter to use different template/output files without re-instantiating the adapter with different parameters.
Suggestions to restore compliance:
Remove constructors that accept
FileSettings
andStream
inputs, and createActionConfig
s for these scenarios. Then modify existing actions to use the action configs instead of the private FileSettings/Stream properties. This would also make determining the actions to use (file settings vs stream usage).This is by definition a breaking change, so versioning will be required, and ensure to update affected toolkits.
The text was updated successfully, but these errors were encountered: