From f9c2c3eef7c3f82e26bd90eb0154850591592b8b Mon Sep 17 00:00:00 2001 From: Thomas Edward Kingstone Date: Tue, 23 Jul 2024 15:54:23 +0100 Subject: [PATCH 1/2] fixed enclosed default typologies so they are fully enclosed --- .../src/ladybugtools_toolkit/external_comfort/typology.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/typology.py b/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/typology.py index da9b4e3a..6dc839a1 100644 --- a/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/typology.py +++ b/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/typology.py @@ -22,7 +22,7 @@ class Typologies(Enum): Shelter.from_adjacent_wall(angle=90), Shelter.from_adjacent_wall(angle=180), Shelter.from_adjacent_wall(angle=270), - Shelter.from_overhead_circle(), + Shelter.from_overhead_circle(height_above_ground=2), ], ) ENCLOSED_POROUS = Typology( @@ -32,7 +32,7 @@ class Typologies(Enum): Shelter.from_adjacent_wall(angle=90).set_porosity(0.5), Shelter.from_adjacent_wall(angle=180).set_porosity(0.5), Shelter.from_adjacent_wall(angle=270).set_porosity(0.5), - Shelter.from_overhead_circle().set_porosity(0.5), + Shelter.from_overhead_circle(height_above_ground=2).set_porosity(0.5), ], ) SKY_SHELTER = Typology( From af490064002ebc0065cc915185b31723a773d0b4 Mon Sep 17 00:00:00 2001 From: Thomas Edward Kingstone Date: Tue, 23 Jul 2024 16:01:54 +0100 Subject: [PATCH 2/2] fixed default values rather than the objects themselves --- .../src/ladybugtools_toolkit/external_comfort/_shelterbase.py | 2 +- .../src/ladybugtools_toolkit/external_comfort/typology.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/_shelterbase.py b/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/_shelterbase.py index 9d72f806..acf3b607 100644 --- a/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/_shelterbase.py +++ b/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/_shelterbase.py @@ -289,7 +289,7 @@ def from_overhead_circle( def from_adjacent_wall( cls, distance_from_wall: float = 1, - wall_height: float = 2, + wall_height: float = 3.5, wall_length: float = 2, wind_porosity: list[float] = (0,) * 8760, radiation_porosity: list[float] = (0,) * 8760, diff --git a/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/typology.py b/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/typology.py index 6dc839a1..da9b4e3a 100644 --- a/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/typology.py +++ b/LadybugTools_Engine/Python/src/ladybugtools_toolkit/external_comfort/typology.py @@ -22,7 +22,7 @@ class Typologies(Enum): Shelter.from_adjacent_wall(angle=90), Shelter.from_adjacent_wall(angle=180), Shelter.from_adjacent_wall(angle=270), - Shelter.from_overhead_circle(height_above_ground=2), + Shelter.from_overhead_circle(), ], ) ENCLOSED_POROUS = Typology( @@ -32,7 +32,7 @@ class Typologies(Enum): Shelter.from_adjacent_wall(angle=90).set_porosity(0.5), Shelter.from_adjacent_wall(angle=180).set_porosity(0.5), Shelter.from_adjacent_wall(angle=270).set_porosity(0.5), - Shelter.from_overhead_circle(height_above_ground=2).set_porosity(0.5), + Shelter.from_overhead_circle().set_porosity(0.5), ], ) SKY_SHELTER = Typology(