Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The number of responses resulting in the Pull is not of the expected length when using BatchRequest #13

Open
epignatelli opened this issue Sep 12, 2019 · 2 comments
Assignees
Labels

Comments

@epignatelli
Copy link
Member

Description:

When using BatchRequests to make concurrent requests, the number of responses is both inconsistent and wrong.

How to replicate:

Use the test file in #12
Switch the toggle on and off a couple of times and check the number of elements that the Pull outputs. It will not be stationary.

Expected behaviour:

If 50 requests are used as input, 50 responses should be returned as output. Some of them can be null

@epignatelli epignatelli added this to the BHoM 2.4 β RC milestone Sep 12, 2019
@epignatelli epignatelli self-assigned this Sep 12, 2019
@epignatelli epignatelli changed the title The number of responses resulting in the Pull is not of the expected length The number of responses resulting in the Pull is not of the expected length when using BatchRequest Sep 26, 2019
@epignatelli
Copy link
Member Author

Bumping to 2.5 RC as this is non critical.
The workaround is to not encapsulate a list of GetRequest into a BatchRequest before pulling.
This will make the requests serial, rather than parallel, but you'll get the expected results

@epignatelli
Copy link
Member Author

Bumping again to 3.1 such that we have the space to solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant