Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Grasshopper UI 2.0 #414

Merged
merged 2 commits into from
Sep 24, 2019

Conversation

adecler
Copy link
Member

@adecler adecler commented Sep 24, 2019

Issues addressed by this PR

Closes #398

Additional comments

By removing the content of 2.0, a few adjustments had to be made for the code to compile again:

  • Delete the UpdateVersion component (component that was updating from 2.0 to 2.1)
  • Removing the using BH.UI.Grasshopper.Base from a few files
  • Move the Logging class from BH.UI.Grasshopper in 2.0 to BH.UI.Grasshopper.Others in 2.1

I have also promoted the content of 2.1 to the root folder as there will be no need to differentiate versions from now on.

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine, code LGTM.

@adecler adecler merged commit 4695c3d into master Sep 24, 2019
@adecler adecler deleted the Grasshopper_Toolkit-#398-RemoveGrasshopperUI_2_0 branch September 24, 2019 13:35
@adecler adecler restored the Grasshopper_Toolkit-#398-RemoveGrasshopperUI_2_0 branch September 30, 2019 16:17
@adecler adecler deleted the Grasshopper_Toolkit-#398-RemoveGrasshopperUI_2_0 branch September 30, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grasshopper_Toolkit: Remove Grasshopper_UI 2.0
2 participants