You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since File_Adapter does not set AdapterConfig.ProcessInMemory, that defaults to true.
This means that the call to Create will always have replaceAll set to true.
If anything, the option for the Create method to override should be specifiable dynamically, rather than hard-coded.
This might be solved by making the so called config parameter available to all CRUD methods.
I would remove replaceAll as a parameter of the Create() and use another parameter like config["CreateOverride"] = true.
The text was updated successfully, but these errors were encountered:
alelom
changed the title
File_Adapter: refactor to match ReplaceInMemory refactoring
File_Adapter: refactoring-refactor to match ReplaceInMemory refactoring
Jul 3, 2019
This issue is being transferred. Timeline may not be complete until it finishes.
Description
As explained in BHoM/BHoM_Adapter#106
Since File_Adapter does not set
AdapterConfig.ProcessInMemory
, that defaults to true.This means that the call to Create will always have
replaceAll
set to true.Therefore the following calls will have
replaceAll
always set to true:https://github.com/BHoM/BHoM_Adapter/blob/49d63e82db3eefa5eecb960e1bd84ab410fc2c51/File_Adapter/CRUD/Create.cs#L40-L46
So these lines never get called
https://github.com/BHoM/BHoM_Adapter/blob/49d63e82db3eefa5eecb960e1bd84ab410fc2c51/File_Adapter/CRUD/Create.cs#L80-L81
As well as this is never called with Append:
https://github.com/BHoM/BHoM_Adapter/blob/49d63e82db3eefa5eecb960e1bd84ab410fc2c51/File_Adapter/CRUD/Create.cs#L57
Proposed change
If anything, the option for the Create method to override should be specifiable dynamically, rather than hard-coded.
This might be solved by making the so called
config
parameter available to all CRUD methods.I would remove
replaceAll
as a parameter of the Create() and use another parameter likeconfig["CreateOverride"] = true
.The text was updated successfully, but these errors were encountered: