Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully Terminate Excel Process on Workbook Close #379

Closed

Conversation

travispotterBH
Copy link

Issues addressed by this PR

Closes #378

Excel process is terminated via applicaiton.Quit() on the workbook that called the App_WorkbookClosed method via the Close Event. Workbook is set to null.

Test files

Any excel file using the BHoM.

Changelog

  • Modified Excel Add-In closing method to ensure full termination of process on workbook close

Additional comments

@travispotterBH travispotterBH added the type:bug Error or unexpected behaviour label Feb 14, 2023
@travispotterBH travispotterBH self-assigned this Feb 14, 2023
@adecler
Copy link
Member

adecler commented Feb 14, 2023

@travispotterBH , Now that the PR is closed, is it ok to delete the branch ?

@travispotterBH
Copy link
Author

Trying other approaches. Excel still hangs and it seems to be caused by excel add in. Please leave branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excel Process Does Not Fully Terminate
2 participants