Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExcelAdapter always target netstandard2.0 #79

Open
IsakNaslundBh opened this issue Jun 24, 2024 · 0 comments · May be fixed by #81
Open

Make ExcelAdapter always target netstandard2.0 #79

IsakNaslundBh opened this issue Jun 24, 2024 · 0 comments · May be fixed by #81
Assignees
Labels
type:compliance Non-conforming to code guidelines

Comments

@IsakNaslundBh
Copy link
Contributor

Broken rules:

If possible, should make sure we only have one build target for Excel_Toolkit, which should be netstandard 2.0, and use for all builds. If works, should also remove additional ZCT build.

Whilst investigating this, it seems this means that the issue with saving larger files found and fixed by @pawelbaran in BHoM/Excel_UI#330 is no longer an issue, and the code and dependencies added to remedy the issue can be removed.

Suggestions to restore compliance:

Change target framework and align.

@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label Jun 24, 2024
@IsakNaslundBh IsakNaslundBh self-assigned this Jun 24, 2024
@IsakNaslundBh IsakNaslundBh changed the title Make ExcelAdapter always target natstandard2.0 Make ExcelAdapter always target netstandard2.0 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant