Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffing_Engine: formalise distinction between Diffing and Hash. #2139

Closed
alelom opened this issue Nov 11, 2020 · 0 comments · Fixed by #2105
Closed

Diffing_Engine: formalise distinction between Diffing and Hash. #2139

alelom opened this issue Nov 11, 2020 · 0 comments · Fixed by #2105
Assignees
Labels
type:feature New capability or enhancement

Comments

@alelom
Copy link
Member

alelom commented Nov 11, 2020

Description:

  • Current HashFragment that stores both current/old hash must be renamed to RevisionFragment. It was designed to be used with a "diffing-revision workflow" anyway (so you can track objects back in time and tell who is new/modified/old).
  • Introduce new HashFragment that only stores the current hash. This is to be used for "diffing-current state workflow".
  • Review the IDiffing() method:
    • to make sure that by default computes HashFragment for objects and uses that (do a "diffing-current state");
    • if instead a RevisionFragment is found on the objects, do a "diffing-revision";
    • make sure that in the "diffing-current state", the property-by-property diffing is off by default (priority must be speed).
    • make sure that in the "diffing-revision", the property-by-property diffing is true by default (priority must be complete comparison).

Also consider:

  • Introduce new HashConfig? To be used as input to the BH.Engine.Base.Query.Hash() method instead of the long list of inputs.
  • Allow conversion/mapping between DiffConfig-HashConfig?
  • Allow conversion between RevisionFragment and HashFragment?

@rolyhudson @al-fisher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant