You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@michaldengusiak the implementation you've done in the PR is not the right implementation. This is why issues should be discussed at least in some small detail either on GitHub, or offline and then notes captured on GitHub for transparency.
The correct implementation for this feature (because I do agree this feature is needed), is to add a method to the BHoM_Engine which takes in arguments of BHoMObject and IFragment. The function should check whether a fragment already exists, and maybe, optionally, provide users the option to replace a fragment if a fragment already exists on the object.
This links in heavily to this issue: BHoM/BHoM#478 which has not yet been resolved.
Therefore, if there is a block to the workflow the correct implementation is described above, and future implementation will want to check fragment attributes per the linked issue.
Description:
As per our discussion, I am creating a method to
AddFragments
to PhysicalElementsThe text was updated successfully, but these errors were encountered: