Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical_Engine: Modify AddFragments #1184

Closed
michaldengusiak opened this issue Sep 11, 2019 · 1 comment · Fixed by #1185
Closed

Physical_Engine: Modify AddFragments #1184

michaldengusiak opened this issue Sep 11, 2019 · 1 comment · Fixed by #1185
Assignees
Labels
type:feature New capability or enhancement

Comments

@michaldengusiak
Copy link
Member

Description:

As per our discussion, I am creating a method to AddFragments to PhysicalElements

@michaldengusiak michaldengusiak added the type:feature New capability or enhancement label Sep 11, 2019
@michaldengusiak michaldengusiak self-assigned this Sep 11, 2019
@FraserGreenroyd
Copy link
Contributor

@michaldengusiak the implementation you've done in the PR is not the right implementation. This is why issues should be discussed at least in some small detail either on GitHub, or offline and then notes captured on GitHub for transparency.

The correct implementation for this feature (because I do agree this feature is needed), is to add a method to the BHoM_Engine which takes in arguments of BHoMObject and IFragment. The function should check whether a fragment already exists, and maybe, optionally, provide users the option to replace a fragment if a fragment already exists on the object.

This links in heavily to this issue: BHoM/BHoM#478 which has not yet been resolved.

Therefore, if there is a block to the workflow the correct implementation is described above, and future implementation will want to check fragment attributes per the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants