Fixes key handling in NetDriver (for WSL anyway)
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Search selected item on filtered set * Fix unit test - don't return first item when combobox is not focused or showed * Improve method readability * Clean selection from previous search * Update unit test - after changing search text unselect previously selected item
…isposing event. (gui-cs#3104)
…t `Command.Accept` (gui-cs#3118) * Command.Accept->Command.ShowContextMenu + Unit Test * fixed unit test
…Width, and/or Height are null or Absolute() (gui-cs#2467) * Merged v2_develop; updated API docs * Code cleanup * Fixed code that was using Dim/Pos before IsInit * Fixed ComboBox using Bounds before IsInitalized and grabbing focus when it shouldn't * Fixed ComboBox tests. Fixed FileDialog * Fixed all !IsInitalized warnings * Fixed AllviewsTester * Fixed CharMap scenario * Fixed ColorPicker (hack) * Fixed CoputedLayout and Csv Editor * Imrpoved warning * Fixed more warnings * Fixed GetTextFormatterSizeNeededForTextAndHotKey * Fixed AllViewsTester * AllViewsTester code cleanup * AllViewsTester code cleanup * AllViewsTester fixed for realz * Decided Fill was better than Percent for default
|
@BDisp I have this working pretty well under WSL now. good enuf for now (and better than Please merge this into your PR and then I'll merge your PR in |
BDisp
pushed a commit
that referenced
this pull request
Dec 7, 2024
Code review comments and cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all
NetDriverunder WSL:a= `à`) (shifted and not)AltGr (US Intl keyboard):
[ConsoleKeyInfo(Key: Null (None), KeyChar: á (225))][ConsoleKeyInfo(Key: 223 (Oem8) | Alt, KeyChar: ß (223))]once)[ConsoleKeyInfo(Key: Null (None), KeyChar: ð (240))]Alt:
[ConsoleKeyInfo(Key: Null (None), KeyChar: ! (33))](OemPeriod) | Alt, KeyChar: . (46))]Ctrl:
[ConsoleKeyInfo(Key: D9 (D9), KeyChar: 9 (57))])ConsoleKeyInfo(Key: P (P) | Control, KeyChar: ␐ (16))])[ConsoleKeyInfo(Key: Tab (Tab), KeyChar: ␉ (9))][ConsoleKeyInfo(Key: D5 (D5) | Control, KeyChar: ␀ (0))]...