Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert automated Nextclade dataset retrieval in favour of fixed datasets and regimented updates #37

Open
jpalmer37 opened this issue Jul 30, 2024 · 0 comments · May be fixed by #38
Open

Comments

@jpalmer37
Copy link
Collaborator

Based on discussions last week, the group seems to prefer the notion of having fixed Nextclade dataset versions in favour of the nextclade dataset get that was implemented for clade calling.

Here are some ideas for changes:

  • remove the nextclade dataset get command and stick with a simple error message if the dataset path is not provided
  • change the metadata.json under the Nextclade dataset path to have a "version" field matching those listed by nextclade (i.e. 2024-07-03--08-29-55Z = latest flu_h1n1 version)
  • add provenance tracking (grep "version" ${dataset}/metadata.json | cut -d'"' -f4) to parse this version out of the metadata.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant