Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6.5 #865

Closed
wants to merge 9 commits into from
Closed

v0.6.5 #865

wants to merge 9 commits into from

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Apr 6, 2023

Unfortunately the initial changes slipped past on master here 700850d

Changes

  • drop Python 3.8
  • drop Python 3.9
  • update minimum scipy and networkx versions

create release PR

  • create a PR that finalizes the code for the next version
    • name the PR according to the version vX.Y.Z and add the release
      tag (example here)
    • make sure CHANGELOG.md is up-to-date and enter current date to the release version
    • add summarized release highlights where appropriate
    • update the CITATION.cff version number and date
    • search the project for deprecated and remove deprecated code
  • wait for review and the CI jobs to finish
  • check the readthedocs PR build

Merge the Pull Request

  • merge normally and wait for all CI actions to finish on the main branch

add Git(hub) tag

  • tag and release the current master version on GitHub using the Releases feature
    • name the release git tag according to the version released (e.g. v0.3.3)
    • name the GitHub release accordingly, omitting the v prefix (this can be change later so don't worry, in
      doubt use vX.Y.Z everywhere)
    • copy the changes/release notes of the current version into the description and change the GitHub PR links to GitHub markdown
  • wait for all Github Actions to finish

ReadTheDocs updates

  • check the build processes for latest, stable and vX.Y.Z get triggered on RTD (the tag build can get
    triggered twice, resulting in a failed/duplicated build, no need to worry)

pypi release

  • check the automatic release to pypi after the build action completes here

conda-forge release

  • pypi release should get picked up by the conda-forge bot and create the new
    pull-request here
  • carefully check the meta.yaml in the pull request, manually update all changes in the build and run dependencies
  • merge with 2 or more approved reviews

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Test Results

       1 files  ±  0         1 suites  ±0   1m 22s ⏱️ - 1m 12s
2 134 tests  - 55  2 048 ✔️  - 140  1 💤 ±0  79 +79  6 🔥 +6 
2 137 runs   - 52  2 048 ✔️  - 140  1 💤 ±0  79 +79  9 🔥 +9 

For more details on these failures and errors, see this check.

Results for commit ad97c80. ± Comparison against base commit 700850d.

This pull request removes 56 and adds 1 tests. Note that renamed tests count towards both.
weldx.tests.test_geometry ‑ test_arc_segment_constructor
weldx.tests.test_geometry ‑ test_arc_segment_factories
weldx.tests.test_geometry ‑ test_arc_segment_interpolation
weldx.tests.test_geometry ‑ test_arc_segment_rasterization
weldx.tests.test_geometry ‑ test_arc_segment_transformations
weldx.tests.test_geometry ‑ test_geometry_construction
weldx.tests.test_geometry ‑ test_geometry_rasterization_profile_interpolation
weldx.tests.test_geometry ‑ test_geometry_rasterization_trace
weldx.tests.test_geometry ‑ test_line_segment_construction
weldx.tests.test_geometry ‑ test_line_segment_interpolation
…
weldx.tests.test_geometry

♻️ This comment has been updated with latest results.

@CagtayFabry
Copy link
Member Author

Python 3.9 seems to run into an issue with the fs package in our test suite https://github.com/BAMWelDX/weldx/actions/runs/4626993379/jobs/8184371412

I could reproduce the error locally but I am nut sure what caused it, Python 3.10 seems to work again for some reason

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #865 (42806c8) into master (e68bb6d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 42806c8 differs from pull request most recent head ad97c80. Consider uploading reports for the commit ad97c80 to get more accurate results

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
+ Coverage   96.48%   96.51%   +0.02%     
==========================================
  Files          94       94              
  Lines        6230     6283      +53     
==========================================
+ Hits         6011     6064      +53     
  Misses        219      219              
Impacted Files Coverage Δ
weldx/asdf/file.py 96.32% <100.00%> (+0.04%) ⬆️
weldx/asdf/util.py 90.88% <100.00%> (ø)
weldx/asdf/validators.py 98.24% <100.00%> (ø)
weldx/config.py 90.66% <100.00%> (ø)
weldx/core/generic_series.py 89.73% <100.00%> (+0.43%) ⬆️
weldx/core/math_expression.py 98.59% <100.00%> (ø)
weldx/core/time_series.py 97.72% <100.00%> (ø)
weldx/geometry.py 96.62% <100.00%> (+0.01%) ⬆️
weldx/tags/core/common_types.py 100.00% <100.00%> (ø)
weldx/time.py 97.88% <100.00%> (+0.04%) ⬆️
... and 4 more

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marscher
Copy link
Collaborator

marscher commented Apr 6, 2023

I've seen this error before. It looks like the given path for the Quality standard is None. So it is not an issue with Python 3.9, but our code.

@CagtayFabry
Copy link
Member Author

I've seen this error before. It looks like the given path for the Quality standard is None. So it is not an issue with Python 3.9, but our code.

yes but it only appears with 3.9 (at least for me)
Anyway, fs seems rather unmaintained and is running into quite a few deprecation warnings, maybe we should try to find an alternative way (using asdf tools)

@marscher
Copy link
Collaborator

marscher commented Apr 6, 2023

the fewer dependencies the fewer points of failure. If asdf.tools provides a an alternative why not use it.

@CagtayFabry CagtayFabry requested a review from marscher April 6, 2023 10:19
@CagtayFabry CagtayFabry changed the title lint and update for py39 v0.6.5 Apr 6, 2023
@CagtayFabry CagtayFabry removed the request for review from marscher April 6, 2023 11:10
@CagtayFabry CagtayFabry closed this Apr 6, 2023
@CagtayFabry CagtayFabry deleted the v0.6.5_dev branch April 6, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants