Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR Microsoft.Azure.Management.Monitor] Introduce go SDK track 2 configurations for monitor #4288

Conversation

openapi-sdkautomation[bot]
Copy link

Create to sync Azure/azure-rest-api-specs#14588

Installation Instructions

In order to use the generated nuget package in your app, you will have to use it from a private feed.
To create a private feed, see the following link:
https://docs.microsoft.com/en-us/nuget/hosting-packages/local-feeds
This will allow you to create a new local feed and add the location of the new feed as one of the sources.

Direct Download

The generated package can be directly downloaded from here:

seanmcc-msft and others added 29 commits June 18, 2021 11:54
…val in Development env. (Azure#21969)

* if not on defaults, honor custom value.

* changelog.
Since track 1 SDKs are deprecated, remove the solution to avoid having
to type the solution name when building from sdk/keyvault each time.
This shouldn't affect the build which enumerates projects within service
directories.
* Add public ctor for SubscriptionValidationResponse

* Comment out package reference.
* Add Stable API Version for point-in-time restore.

* Newly generated SDK from latest swagger

* Updating testcases to fix the CI break.

* Fixing test errors

* Fixed failing tests

* Updated SDK Version and updated release notes.

* Bumping up AssemblyVersion/AssemblyFileVersion("3.1.0.0") from ("3.0.0.0")
Also gets rid of unnecessary, deprecated enableSoftDelete parameter.
Azure#21968)

* Fixed pipeline break

* 100% methods have protocol overloads

* API cleanup

* Update API file

* renamed message to content

* bug fix and parameter validation
* Add asserts to verify all actions are counted for pending queue

* Increase timeout of test
Bumps [log4net](https://github.com/apache/logging-log4net) from 2.0.3 to 2.0.10.
- [Release notes](https://github.com/apache/logging-log4net/releases)
- [Changelog](https://github.com/apache/logging-log4net/blob/master/ReleaseInstructions.txt)
- [Commits](https://github.com/apache/logging-log4net/commits/rel/2.0.10)

---
updated-dependencies:
- dependency-name: log4net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update links with master to use main

* Update ci.yml files

Co-authored-by: Chidozie Ononiwu <[email protected]>
* Fix storage extension build

* Add project reference

* Shadow type

* Camel case
…re#22009)

* Fix typo: `AmqpSendAuthenticanToken` → `AmqpSendAuthenticationToken`
* Fix claims: `System.String[]` → `Manage,Listen`
* Clean up clients comments.

* Models updates to introduce CallConnection and Server.

* callState updated to callConnectionState, replace sourceAlternateIdentity with alternateCallerId, other fixes

* Update to the test sample.

* Updated the swagger path, removed delete operation, updated unit tests and live tests

* Updates based on comments

* Zihzhan/fix (Azure#21727)

* Clean up clients comments.

* Update Snippet and Export-API.

* Zihzhan/fix (Azure#21764)

* Update Snippet and Export-API.

* remove calloption override in servercall client.

* Nit for params and arguments handling.

* Merge Downloader updates.

* Merge Downloader updates test cases.

* Update AutoGen Content.

* Model name updates (Suffix for responses models now has Result instead of Response), fixes based on comments (Azure#21790)

* Zihzhan/fix (Azure#21805)

* Update Snippet and Export-API.

* remove calloption override in servercall client.

* Nit for params and arguments handling.

* Merge Downloader updates.

* Merge Downloader updates test cases.

* Update AutoGen Content.

* Nit clean on Unit Tests.

* Updating and renaming.

* The changes which are done: (Azure#21863)

InviteParticipants --> AddParticipant
InviteParticipantResultEvent --> AddParticipantResultEvent
CallModality --> MediaType
CommunicationParticipant --> CallParticipant
Id in PlayAudioResult & CancelAllMediaOperations is now called OperationId
CallConnectionState now has {incoming, connecting, connected, disconnecting, disconnected}
CallRecordingStateResult ---> CallRecording... by Naveed Ali
CallRecordingStateResult ---> CallRecordingProperties

* Fix build Anaylse.

* fix(tests): improve code coverage

* Added AddParticipantResult, Re-added communication error, updated swagger path (Azure#21870)

* Added AddParticipantResult, Re-added communication error, updated swagger path

* Fixed unit tests

* Updated netstandard

* Analysis fix

* Updated event type for add participant

* Fix build issue.

* Zihzhan/fix (Azure#21905)

* Update Snippet and Export-API.

* remove calloption override in servercall client.

* Nit for params and arguments handling.

* Merge Downloader updates.

* Merge Downloader updates test cases.

* Update AutoGen Content.

* Nit clean on Unit Tests.

* Updating and renaming.

* Test update.

* Add Call Connection Live Tests.

* Add ServerCall Live Tests

* Increase Test Coverage.

* Reenable sample tests.

* Zihzhan/fix (Azure#21931)

* Update Snippet and Export-API.

* remove calloption override in servercall client.

* Nit for params and arguments handling.

* Merge Downloader updates.

* Merge Downloader updates test cases.

* Update AutoGen Content.

* Nit clean on Unit Tests.

* Updating and renaming.

* Test update.

* Add Call Connection Live Tests.

* Add ServerCall Live Tests

* Increase Test Coverage.

* Reenable sample tests.

* Address comments.

* Point to swagger file in master branch.

* Zihzhan/fix (Azure#21950)

* Update Snippet and Export-API.

* remove calloption override in servercall client.

* Nit for params and arguments handling.

* Merge Downloader updates.

* Merge Downloader updates test cases.

* Update AutoGen Content.

* Nit clean on Unit Tests.

* Updating and renaming.

* Test update.

* Add Call Connection Live Tests.

* Add ServerCall Live Tests

* Increase Test Coverage.

* Reenable sample tests.

* Address comments.

* Point to swagger file in master branch.

* Nit fix.

* Nit changes based on Azure boarder review feedback.

* Address comments.

* Naming changes.

* Change to static connection string.

* Add methods that support Live Test.

* Moved Recorded value inside the test method.

* Updated models definition based on new swagger plus updated events properties to readonly (Azure#21980)

* Updated models definition based on new swagger, also fixed events to make properties readonly

* Update accessibility of internal models

* Update the file path in autorest

* Update auto gen apis.

* Rewrite the event tests and fixed json for other tests (Azure#21983)

* Disable AddParticipant test in Live mode.

* Moved modelfactory to .models namespace (Azure#22021)

Co-authored-by: zihzhan <[email protected]>
Co-authored-by: Zihan Zhang <[email protected]>
Co-authored-by: Christian Whitehead <[email protected]>
* Update pipeline generation tool version

Consume latest changes from pipeline generation tool in Azure/azure-sdk-tools#1708

* Update tool version to include fix for public ci

Co-authored-by: Wes Haggard <[email protected]>
* Update AutoRest C# version to 3.0.0-beta.20210621.1

* [WebPubSub] requestOptions -> options

* Run Export-API

Co-authored-by: Matt Ellis <[email protected]>
The `DateTime` and `DateTimeOffset` test values in `AmqpMessageBodyTests.s_amqpValues` were created with `DateTimeOffset.Parse`, which would fail with the following exception when run on a system with a non-US culture:
```
System.TypeInitializationException : The type initializer for 'Azure.Core.Amqp.Tests.AmqpMessageBodyTests' threw an exception.
  ----> System.FormatException : String was not recognized as a valid DateTime.
   at Azure.Core.Amqp.Tests.AmqpMessageBodyTests..ctor()
--FormatException
   at System.DateTimeParse.Parse(String s, DateTimeFormatInfo dtfi, DateTimeStyles styles, TimeSpan& offset)
   at System.DateTimeOffset.Parse(String input)
   at Azure.Core.Amqp.Tests.AmqpMessageBodyTests..cctor()
```

By using `new DateTimeOffset(2021, 3, 24, 0, 0, 0, TimeSpan.Zero)` instead of `DateTimeOffset.Parse("3/24/21")` we ensure that the tests pass on any system regardless of its configured culture.
Increment package version after release of Azure.Messaging.EventGrid
pakrym and others added 25 commits June 25, 2021 18:02
* Create new SDK for VMSS

* Add Tests

* Add SDK for VMSS

* Recreate the generated folder

* Regenerate the metadata file

Co-authored-by: Aashish Rajaram Salokhe <[email protected]>
# All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.
- [ ] **Please open PR in `Draft` mode if it is:**
	- Work in progress or not intended to be merged.
	- Encountering multiple pipeline failures and working on fixes.
- [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
- [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md).**
- [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).**

### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#general-guidelines)
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#testing-guidelines)
- [ ] Pull request includes test coverage for the included changes.

### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#sdk-generation-guidelines)
- [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
- [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version.

## Additional management plane SDK specific contribution checklist: 
Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]`
 
- [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/master/eng/mgmt/mgmtmetadata).
- [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

### Management plane SDK Troubleshooting
- If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer.
- If the check fails at the `Verify Code Generation` step, please ensure:
	- Do not modify any code in generated folders.
	- Do not selectively include/remove generated files in the PR.
	- Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly.
	Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
	
	**Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**:

	    `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

### Old outstanding PR cleanup
 Please note:
	If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
* [Identity] Adding regional STS support

* update changelog

* update api spec

* adding AZURE_REGIONAL_AUTHORITY_NAME environment variable support

* fix build issue from merge

* fix implicit casting of environment variable

* fixing merge issues

* fixing implicit RegionalAuthority cast issue
The focus of these changes is to refactor the `AmqpMessageConverter` to
perform translation based on the full `AmqpAnnotatedMessage` rather than
the `EventData` projection, as had previously been done.
…ctivity.Parent.SpanId (Azure#20434)

* Include ai.operation.parentId from ParentSpanId

* Refactor ParentSpanId test

* Revert unintentional change in TagTests

Co-authored-by: Magnus Gideryd <[email protected]>
* Continue renewing lock while processing

* Fix transaction tests

* Fix docs for SBClient
* Update AutoRest C# version to 3.0.0-beta.20210628.2

* Fix build

* Remove CodeGenSuppress from EventGrid

* Exclude Azure.Core.CodeGenSuppressAttribute from API listing

Co-authored-by: azure-sdk <[email protected]>
* added key byte cache to the policy

* fixed a bug
* docstring fixes for Upload() and UploadAsync()

* fully qualified reference to BlockBlobClient

Co-authored-by: jschrepp-MSFT <[email protected]>
- Replace myself with Anne as synapse owner as I'm off to adventures in Go-Land ™️

# All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.
- [ ] **Please open PR in `Draft` mode if it is:**
	- Work in progress or not intended to be merged.
	- Encountering multiple pipeline failures and working on fixes.
- [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
- [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).**
- [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).**

### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines)
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines)
- [ ] Pull request includes test coverage for the included changes.

### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines)
- [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
- [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version.

## Additional management plane SDK specific contribution checklist: 
Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]`
 
- [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata).
- [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

### Management plane SDK Troubleshooting
- If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer.
- If the check fails at the `Verify Code Generation` step, please ensure:
	- Do not modify any code in generated folders.
	- Do not selectively include/remove generated files in the PR.
	- Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly.
	Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
	
	**Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**:

	    `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

### Old outstanding PR cleanup
 Please note:
	If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
* Add System.Text.Json converter for EventGridEvent

* Usings

* Fix docs

* Use more efficient parse
Co-authored-by: Christopher Scott <[email protected]>
Co-authored-by: Scott Addie <[email protected]>
- Update AutoRest C# version to 3.0.0-beta.20210628.4
- Fix WebPubSub to expect new generated code patterns
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14588/Microsoft.Azure.Management.Monitor branch 2 times, most recently from 3f49e12 to be72651 Compare June 30, 2021 00:17
Merge 3c67592066e75e1e972d7ce54d9aa67782d947c5 into c51580c6f102bace66c5bed4b979437c21b81882
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14588/Microsoft.Azure.Management.Monitor branch from be72651 to 919d2ae Compare June 30, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.