diff --git a/sdk/keyvault/keyvault-certificates/CHANGELOG.md b/sdk/keyvault/keyvault-certificates/CHANGELOG.md index e6fa54384b64..26e88ef8bf3d 100644 --- a/sdk/keyvault/keyvault-certificates/CHANGELOG.md +++ b/sdk/keyvault/keyvault-certificates/CHANGELOG.md @@ -5,6 +5,7 @@ - [Breaking] Removed `dist-browser` from the published package. To bundle the Azure SDK libraries for the browsers, please read our bundling guide: [link](https://github.com/Azure/azure-sdk-for-js/blob/master/documentation/Bundling.md). - Updated the Key Vault Certificates Long Running Operation Pollers to follow a more compact and meaningful approach moving forward. - Bug fix: The logging of HTTP requests wasn't properly working - now it has been fixed and tests have been written that verify the fix. +- Removed `parseKeyVaultCertificatesIdentifier` from the public API. ## 4.2.0-beta.1 (2020-09-11) diff --git a/sdk/keyvault/keyvault-certificates/review/keyvault-certificates.api.md b/sdk/keyvault/keyvault-certificates/review/keyvault-certificates.api.md index fa9a2240f89b..53cead6e5154 100644 --- a/sdk/keyvault/keyvault-certificates/review/keyvault-certificates.api.md +++ b/sdk/keyvault/keyvault-certificates/review/keyvault-certificates.api.md @@ -421,9 +421,6 @@ export const logger: import("@azure/logger").AzureLogger; // @public export type MergeCertificateOptions = coreHttp.OperationOptions; -// @public -export function parseKeyVaultCertificateId(id: string): KeyVaultCertificateId; - export { PipelineOptions } // @public diff --git a/sdk/keyvault/keyvault-certificates/src/identifier.ts b/sdk/keyvault/keyvault-certificates/src/identifier.ts index b6bff5f3345b..f429e511d8d6 100644 --- a/sdk/keyvault/keyvault-certificates/src/identifier.ts +++ b/sdk/keyvault/keyvault-certificates/src/identifier.ts @@ -46,6 +46,7 @@ export interface KeyVaultCertificateId { * } *``` * @param id - The Id of the Key Vault Certificate. + * @internal */ export function parseKeyVaultCertificateId(id: string): KeyVaultCertificateId { const urlParts = id.split("/"); diff --git a/sdk/keyvault/keyvault-certificates/src/index.ts b/sdk/keyvault/keyvault-certificates/src/index.ts index 97d0e4995d21..58a446d0a388 100644 --- a/sdk/keyvault/keyvault-certificates/src/index.ts +++ b/sdk/keyvault/keyvault-certificates/src/index.ts @@ -141,7 +141,7 @@ import { DeleteCertificateState } from "./lro/delete/operation"; import { CreateCertificateState } from "./lro/create/operation"; import { RecoverDeletedCertificateState } from "./lro/recover/operation"; import { parseCertificateBytes } from "./utils"; -import { parseKeyVaultCertificateId, KeyVaultCertificateId } from "./identifier"; +import { KeyVaultCertificateId } from "./identifier"; import { coreContactsToCertificateContacts, getCertificateFromCertificateBundle, @@ -168,7 +168,6 @@ export { BeginRecoverDeletedCertificateOptions, KeyVaultCertificate, KeyVaultCertificateWithPolicy, - parseKeyVaultCertificateId, BackupCertificateOptions, CertificateContentType, CertificateProperties, diff --git a/sdk/keyvault/keyvault-certificates/test/public/identifier.spec.ts b/sdk/keyvault/keyvault-certificates/test/public/identifier.spec.ts index bfbd18e3b343..7e4eb46bc43b 100644 --- a/sdk/keyvault/keyvault-certificates/test/public/identifier.spec.ts +++ b/sdk/keyvault/keyvault-certificates/test/public/identifier.spec.ts @@ -1,7 +1,7 @@ // Copyright (c) Microsoft Corporation. // Licensed under the MIT license. -import { parseKeyVaultCertificateId } from "../../src"; +import { parseKeyVaultCertificateId } from "../../src/identifier"; import * as assert from "assert"; describe("Key Vault Certificates Identifier", () => { diff --git a/sdk/keyvault/keyvault-keys/CHANGELOG.md b/sdk/keyvault/keyvault-keys/CHANGELOG.md index 96e92f8d73da..49f126d7e01c 100644 --- a/sdk/keyvault/keyvault-keys/CHANGELOG.md +++ b/sdk/keyvault/keyvault-keys/CHANGELOG.md @@ -5,8 +5,9 @@ - [Breaking] Removed `dist-browser` from the published package. To bundle the Azure SDK libraries for the browsers, please read our bundling guide: [link](https://github.com/Azure/azure-sdk-for-js/blob/master/documentation/Bundling.md). - Updated the Key Vault Keys Long Running Operation Pollers to follow a more compact and meaningful approach moving forward. - Bug fix: The logging of HTTP requests wasn't properly working - now it has been fixed and tests have been written that verify the fix. -- Add a constructor overload to `CryptographyClient` that takes a `JsonWebKey` and allows for local-only subset of operations. -- Add `KeyId` to the public API of CryptographyClient. +- Added a constructor overload to `CryptographyClient` that takes a `JsonWebKey` and allows for local-only subset of operations. +- Added `KeyId` to the public API of CryptographyClient. +- Removed `parseKeyVaultKeysId` from the public API and made `KeyOptionsOptions.additionalAuthenticatedData` a readonly property. ## 4.2.0-beta.2 (2020-10-06) diff --git a/sdk/keyvault/keyvault-keys/review/keyvault-keys.api.md b/sdk/keyvault/keyvault-keys/review/keyvault-keys.api.md index 94e6927539ef..36bd2a2b5b80 100644 --- a/sdk/keyvault/keyvault-keys/review/keyvault-keys.api.md +++ b/sdk/keyvault/keyvault-keys/review/keyvault-keys.api.md @@ -189,7 +189,7 @@ export type KeyOperation = string; // @public export interface KeyOperationsOptions extends CryptographyOptions { - additionalAuthenticatedData?: Uint8Array; + readonly additionalAuthenticatedData?: Uint8Array; iv?: Uint8Array; tag?: Uint8Array; } @@ -340,9 +340,6 @@ export { PagedAsyncIterableIterator } export { PageSettings } -// @public -export function parseKeyVaultKeyId(id: string): KeyVaultKeyId; - export { PipelineOptions } export { PollerLike } diff --git a/sdk/keyvault/keyvault-keys/src/cryptographyClientModels.ts b/sdk/keyvault/keyvault-keys/src/cryptographyClientModels.ts index 301fa9043e6e..436f8608582a 100644 --- a/sdk/keyvault/keyvault-keys/src/cryptographyClientModels.ts +++ b/sdk/keyvault/keyvault-keys/src/cryptographyClientModels.ts @@ -147,7 +147,7 @@ export interface KeyOperationsOptions extends CryptographyOptions { * Additional data to authenticate but not encrypt/decrypt when using authenticated crypto * algorithms. */ - additionalAuthenticatedData?: Uint8Array; + readonly additionalAuthenticatedData?: Uint8Array; /** * The tag to authenticate when performing decryption with an authenticated algorithm. */ diff --git a/sdk/keyvault/keyvault-keys/src/identifier.ts b/sdk/keyvault/keyvault-keys/src/identifier.ts index 59374e4f9820..88f6f6269162 100644 --- a/sdk/keyvault/keyvault-keys/src/identifier.ts +++ b/sdk/keyvault/keyvault-keys/src/identifier.ts @@ -47,6 +47,7 @@ export interface KeyVaultKeyId { *``` * @param id - The Id of the Key Vault Key. + * @internal */ export function parseKeyVaultKeyId(id: string): KeyVaultKeyId { const urlParts = id.split("/"); diff --git a/sdk/keyvault/keyvault-keys/src/index.ts b/sdk/keyvault/keyvault-keys/src/index.ts index 854c9d3ba594..0186fa36b410 100644 --- a/sdk/keyvault/keyvault-keys/src/index.ts +++ b/sdk/keyvault/keyvault-keys/src/index.ts @@ -132,7 +132,6 @@ export { KeyType, KnownKeyTypes, KeyPollerOptions, - parseKeyVaultKeyId, BeginDeleteKeyOptions, BeginRecoverDeletedKeyOptions, KeyProperties, diff --git a/sdk/keyvault/keyvault-secrets/review/keyvault-secrets.api.md b/sdk/keyvault/keyvault-secrets/review/keyvault-secrets.api.md index d283d6bbcbaf..533979a8ba74 100644 --- a/sdk/keyvault/keyvault-secrets/review/keyvault-secrets.api.md +++ b/sdk/keyvault/keyvault-secrets/review/keyvault-secrets.api.md @@ -92,9 +92,6 @@ export { PagedAsyncIterableIterator } export { PageSettings } -// @public -export function parseKeyVaultSecretId(id: string): KeyVaultSecretId; - export { PipelineOptions } export { PollerLike } diff --git a/sdk/keyvault/keyvault-secrets/src/identifier.ts b/sdk/keyvault/keyvault-secrets/src/identifier.ts index 4102107346d4..7281c5d023c9 100644 --- a/sdk/keyvault/keyvault-secrets/src/identifier.ts +++ b/sdk/keyvault/keyvault-secrets/src/identifier.ts @@ -46,6 +46,7 @@ export interface KeyVaultSecretId { * } *``` * @param id - The Id of the Key Vault Secret. + * @internal */ export function parseKeyVaultSecretId(id: string): KeyVaultSecretId { const urlParts = id.split("/"); diff --git a/sdk/keyvault/keyvault-secrets/src/index.ts b/sdk/keyvault/keyvault-secrets/src/index.ts index e72ceee048cf..22f9c733a4a3 100644 --- a/sdk/keyvault/keyvault-secrets/src/index.ts +++ b/sdk/keyvault/keyvault-secrets/src/index.ts @@ -61,7 +61,7 @@ import { SecretClientOptions, LATEST_API_VERSION } from "./secretsModels"; -import { parseKeyVaultSecretId, KeyVaultSecretId } from "./identifier"; +import { KeyVaultSecretId } from "./identifier"; import { getSecretFromSecretBundle } from "./transformations"; export { @@ -84,7 +84,6 @@ export { PollerLike, PollOperationState, KeyVaultSecret, - parseKeyVaultSecretId, SecretProperties, SecretPollerOptions, BeginDeleteSecretOptions, diff --git a/sdk/keyvault/keyvault-secrets/test/public/identifier.spec.ts b/sdk/keyvault/keyvault-secrets/test/public/identifier.spec.ts index b4b67954b0ce..1ac4b1449f10 100644 --- a/sdk/keyvault/keyvault-secrets/test/public/identifier.spec.ts +++ b/sdk/keyvault/keyvault-secrets/test/public/identifier.spec.ts @@ -1,7 +1,7 @@ // Copyright (c) Microsoft Corporation. // Licensed under the MIT license. -import { parseKeyVaultSecretId } from "../../src"; +import { parseKeyVaultSecretId } from "../../src/identifier"; import * as assert from "assert"; describe("Key Vault Secrets Identifier", () => { diff --git a/sdk/operationalinsights/arm-operationalinsights/LICENSE.txt b/sdk/operationalinsights/arm-operationalinsights/LICENSE.txt index ea8fb1516028..2d3163745319 100644 --- a/sdk/operationalinsights/arm-operationalinsights/LICENSE.txt +++ b/sdk/operationalinsights/arm-operationalinsights/LICENSE.txt @@ -1,6 +1,6 @@ The MIT License (MIT) -Copyright (c) 2020 Microsoft +Copyright (c) 2021 Microsoft Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal diff --git a/sdk/operationalinsights/arm-operationalinsights/src/models/index.ts b/sdk/operationalinsights/arm-operationalinsights/src/models/index.ts index 7ad0bf333eac..f87a8b138191 100644 --- a/sdk/operationalinsights/arm-operationalinsights/src/models/index.ts +++ b/sdk/operationalinsights/arm-operationalinsights/src/models/index.ts @@ -22,7 +22,7 @@ export interface DataExport extends BaseResource { /** * An array of tables to export, for example: [“Heartbeat, SecurityEvent”]. */ - tableNames?: string[]; + tableNames: string[]; /** * The destination resource ID. This can be copied from the Properties entry of the destination * resource in Azure. diff --git a/sdk/operationalinsights/arm-operationalinsights/src/models/mappers.ts b/sdk/operationalinsights/arm-operationalinsights/src/models/mappers.ts index f39fbab6dcaa..a8a87a35f6a0 100644 --- a/sdk/operationalinsights/arm-operationalinsights/src/models/mappers.ts +++ b/sdk/operationalinsights/arm-operationalinsights/src/models/mappers.ts @@ -25,6 +25,7 @@ export const DataExport: msRest.CompositeMapper = { } }, tableNames: { + required: true, serializedName: "properties.tableNames", type: { name: "Sequence",