Remove osm-arc validations #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nshankar <[email protected]>
nshankar13
requested review from
NarayanThiru,
bavneetsingh16,
deeksha345 and
anagg929
as code owners
|
what is the reason for removing this validation? Is it not applicable anymore? Can you pl. update the PR description with details? |
|
@nshankar13, what is the reason for removing this validation? Is it not applicable anymore? Can you pl. update the PR description with details? |
NarayanThiru
requested changes
Jun 18, 2024
| @@ -52,8 +52,8 @@ def Create(self, cmd, client, resource_group_name, cluster_name, name, cluster_t | |||
| # NOTE-2: Return a valid Extension object, Instance name and flag for Identity | |||
| create_identity = True | |||
|
|
|||
| if cluster_type == "connectedClusters": | |||
| _validate_tested_distro(cmd, resource_group_name, cluster_name, version, release_train) | |||
| # if cluster_type == "connectedClusters": | |||
There was a problem hiding this comment.
If you don't need this validation anymore, remove the code altogether, not leave it commented out. If you need it later, you will still be able to recover from this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az k8s-extension create --cluster-name --resource-group --cluster-type connectedClusters --extension-type Microsoft.openservicemesh --scope cluster -release-train stable --name osm --release-namespace arc-osm-system --version 1.2.9 --auto-upgrade-minor-version false
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.