use clientinfo endpoint to determine home object id and home tenant i… #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for guest scenarios
pmaytak
approved these changes
May 27, 2020
Comment on lines
+13
to
+14
| private const string Uid = "Uid"; | ||
| private const string Utid = "Utid"; |
There was a problem hiding this comment.
These two can still use TestConstants. The tests don't depend on the actual value.
| @@ -11,33 +11,45 @@ public class ClaimsPrincipalExtensionsTests | |||
| { | |||
| private const string Name = "name-value"; | |||
| private const string NameV1 = "name_V1-value"; | |||
| private const string ObjectId = "objectId-value"; | |||
There was a problem hiding this comment.
👍 for moving stuff into constants.
| @@ -265,25 +277,25 @@ public void GetLoginHint_NoNameClaims_ReturnsNull() | |||
| [Fact] | |||
| public void GetMsalAccountId_WithNeededClaims_ReturnsFormattedMsalId() | |||
| { | |||
| var b2cPattern = $"{Utid}.{Tid}"; | |||
| var aadPattern = $"{Oid}.{Tid}"; | |||
| var b2cPattern = $"{TestConstants.Uid}-{TestConstants.B2CSignUpSignInUserFlow}.{TestConstants.Utid}"; | |||
Co-authored-by: pmaytak <[email protected]>
Co-authored-by: pmaytak <[email protected]>
Co-authored-by: pmaytak <[email protected]>
Co-authored-by: pmaytak <[email protected]>
Co-authored-by: pmaytak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d for guest scenarios
Fix for #18