Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Use the new AzureAD key issuer validator in AddMicrosoftIdentityWebApi #2323

Closed
jmprieur opened this issue Jul 11, 2023 · 2 comments · Fixed by #2325 or #2356
Closed

[Feature Request] Use the new AzureAD key issuer validator in AddMicrosoftIdentityWebApi #2323

jmprieur opened this issue Jul 11, 2023 · 2 comments · Fixed by #2325 or #2356
Labels
enhancement New feature or request feature request

Comments

@jmprieur
Copy link
Collaborator

jmprieur commented Jul 11, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
IdentityModel now exposes a new AAD specific implementation for a delegate validating keys issuer. AddMicrosoftIdentityWebApi could benefit from it.
For details, see AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2134

Describe the solution you'd like
Add the validation of the keys issuer, by calling mergedOptions.TokenValidationParameters.EnableAadSigningKeyIssuerValidation() for instance here
@jmprieur jmprieur added enhancement New feature or request feature request labels Jul 11, 2023
@westin-m westin-m linked a pull request Jul 12, 2023 that will close this issue
update wilson version and add key issuer validation #2325
Merged
@jennyf19
Copy link
Collaborator

https://github.com/AzureAD/microsoft-identity-web/releases/tag/2.13.0

@jennyf19 jennyf19 mentioned this issue Jul 17, 2023
Merged
@jmprieur jmprieur mentioned this issue Jul 30, 2023
Merged
@jennyf19
Copy link
Collaborator

Included in 2.13.2 release

@twsouthwick twsouthwick mentioned this issue Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature request
Projects
None yet
Milestone
No milestone
2 participants
@jmprieur @jennyf19