Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Id property in CredentialDescription is derived from secret values #147

Closed
msbw2 opened this issue Jan 20, 2025 · 0 comments · Fixed by #148
Closed

[Bug] Id property in CredentialDescription is derived from secret values #147

msbw2 opened this issue Jan 20, 2025 · 0 comments · Fixed by #148
Labels
bug Something isn't working

Comments

@msbw2
Copy link
Contributor

msbw2 commented Jan 20, 2025 •
edited
Loading

Refer to AzureAD/microsoft-identity-web#3201 (no longer available)

Problematic code:

microsoft-identity-abstractions-for-dotnet/src/Microsoft.Identity.Abstractions/ApplicationOptions/CredentialDescription.cs

Lines 343 to 350 in 38dbb1d

CredentialSource.KeyVault => KeyVaultCertificateName,
CredentialSource.SignedAssertionFromVault => KeyVaultCertificateName,
CredentialSource.Path => CertificatePassword,
CredentialSource.StoreWithThumbprint => CertificateThumbprint,
CredentialSource.StoreWithDistinguishedName => CertificateDistinguishedName,
CredentialSource.Certificate or CredentialSource.Base64Encoded => Base64EncodedValue,
CredentialSource.SignedAssertionFromManagedIdentity => ManagedIdentityClientId,
CredentialSource.ClientSecret => ClientSecret,

@jennyf19 jennyf19 added bug Something isn't working and removed needs attention untriaged labels Jan 21, 2025
@msbw2 msbw2 changed the title [Bug] Id field in CredentialDescription is derived from secret values [Bug] Id property in CredentialDescription is derived from secret values Jan 21, 2025
jmprieur added a commit that referenced this issue Jan 21, 2025
@jmprieur
Fix #147 and mop-up update of Public API
2a71d67
@jmprieur jmprieur mentioned this issue Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #147 AzureAD/microsoft-identity-abstractions-for-dotnet
2 participants
@jennyf19 @msbw2