Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

WSTrustRequest.acquire_token does not have a timeout #121

Closed
mideeks opened this issue Feb 24, 2018 · 1 comment · Fixed by #125
Closed

WSTrustRequest.acquire_token does not have a timeout #121

mideeks opened this issue Feb 24, 2018 · 1 comment · Fixed by #125

Comments

@mideeks
Copy link

mideeks commented Feb 24, 2018

There is no timeout set on the requests.post() call in this function on line 147. This manifests as occasional infinite hangs for us in our scripts when the upstream server has problems.
@rayluo
Copy link
Collaborator

rayluo commented Feb 28, 2018

Thanks for the report. We will take a look into this.

@rayluo rayluo mentioned this issue Mar 2, 2018
Merged
@rayluo rayluo mentioned this issue Mar 7, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add timeout for WSTrust AzureAD/azure-activedirectory-library-for-python
2 participants
@rayluo @mideeks