This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
Jennyf/ios broker fixes #1614
Merged
Jennyf/ios broker fixes #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jun 10, 2019
| else | ||
| { | ||
| // error_domain is a required field in a failed iOS broker response | ||
| tokenResponse.Error = responseDictionary[TokenResponseClaim.ErrorDomain]; |
There was a problem hiding this comment.
Does MSAL have this logic? #Resolved
There was a problem hiding this comment.
bgavrilMS
reviewed
Jun 10, 2019
| { | ||
| public const string CacheKeyDelimiter = "-"; | ||
| private const bool _defaultSyncSetting = false; | ||
| private const SecAccessible _defaultAccessiblityPolicy = SecAccessible.AfterFirstUnlockThisDeviceOnly; |
There was a problem hiding this comment.
const have different style, like the one at line 45 #Resolved
bgavrilMS
reviewed
Jun 10, 2019
| @@ -36,9 +36,24 @@ | |||
|
|
|||
| namespace Microsoft.Identity.Core | |||
| { | |||
| internal class iOSTokenCacheAccessor : ITokenCacheAccessor | |||
| internal class iOSTokenCacheAccessor : ITokenCacheAccessor, ILegacyCachePersistence | |||
There was a problem hiding this comment.
This is for backwards compat with ADAL v3. I would rather not do this unless there are customers who cannot use MSAL directly. ADAL v3 -> ADAL v5 / MSAL never worked as far as I can tell. #Resolved
|
I think the extra logging and the error description changes are fine and should be commited (please do). I would not make changes the to the iOS accessor. #Resolved |
|
yeah...sure...sounds good. In reply to: 500560924 [](ancestors = 500560924) |
bgavrilMS
approved these changes
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add logging
fix teamId default
fix keychain w/legacy cache persistence
fix issue with null ref
Tested w/iOS device w/broker (v2) and w/ interactive/silent flows and w/ and w/out the SetIosKeychainProperty
build passed here