TokenCache before/after access notifications need to be within the cachelock boundary #1571

MarkZuber · 2019-04-03T20:02:16Z

Which Version of ADAL are you using ?
ADAL 5.0.1-preview

TokenCache access before/after notifications need to be within the _cacheLock lock in order for contract with the extensions file cache locking story to work. Attached is screen shot of deadlock in VS. Currently the before/after notifications are fired individually within the locks at the AcquireTokenHandlerBase level and encompass possibly more than one access to the cache.

MarkZuber added v5 VS labels Apr 3, 2019

MarkZuber added this to the 5.0.2 milestone Apr 3, 2019

MarkZuber self-assigned this Apr 3, 2019

MarkZuber mentioned this issue Apr 3, 2019

Fix cache notification locking semantics [1571] #1572

Merged

MarkZuber added the Fixed label Apr 4, 2019

MarkZuber closed this as completed Apr 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TokenCache before/after access notifications need to be within the cachelock boundary #1571

TokenCache before/after access notifications need to be within the cachelock boundary #1571

MarkZuber commented Apr 3, 2019

TokenCache before/after access notifications need to be within the cachelock boundary #1571

TokenCache before/after access notifications need to be within the cachelock boundary #1571

Comments

MarkZuber commented Apr 3, 2019