Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test in Microsoft.IdentityModel.Protocols.SignedHttpRequest.Tests #3035

Closed
iNinja opened this issue Nov 25, 2024 · 0 comments · Fixed by #3037
Closed

Flaky test in Microsoft.IdentityModel.Protocols.SignedHttpRequest.Tests #3035

iNinja opened this issue Nov 25, 2024 · 0 comments · Fixed by #3037
Labels
Flaky test Good First Issue This is a good item for new team members Internal Indicates issue was opened by the IdentityModel team

Comments

@iNinja
Copy link
Contributor

iNinja commented Nov 25, 2024

The following test:

azure-activedirectory-identitymodel-extensions-for-dotnet/test/Microsoft.IdentityModel.Protocols.SignedHttpRequest.Tests/PopKeyResolvingTests.cs

Line 809 in d38c890

new ResolvePopKeyTheoryData("Valid0KeysReturnedLive")
, appears to be failing quite regularly as of lately.

The test itself is making an HTTP request to http://www.contoso.com, which redirects to microsoft.com, and from the test results, it seems that the request sometimes takes over 10 seconds, causing it to be cancelled and failing the test.
@iNinja iNinja added the Internal Indicates issue was opened by the IdentityModel team label Nov 25, 2024
@jennyf19 jennyf19 added Flaky test Good First Issue This is a good item for new team members labels Nov 25, 2024
@iNinja iNinja mentioned this issue Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Flaky test Good First Issue This is a good item for new team members Internal Indicates issue was opened by the IdentityModel team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SignedHttpRequest flaky test AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet
2 participants
@iNinja @jennyf19