Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make "kid" Configuration for JsonWebToken Optional #2960

Closed
sruke opened this issue Oct 31, 2024 · 3 comments · Fixed by #2968
Closed

[Feature Request] Make "kid" Configuration for JsonWebToken Optional #2960

sruke opened this issue Oct 31, 2024 · 3 comments · Fixed by #2968
Assignees
Labels
Enhancement The issue is a new feature
Milestone

Comments

@sruke
Copy link
Contributor

sruke commented Oct 31, 2024

What: Introduce a configuration option for adding the "kid" to the JsonWebToken.

Why: Currently, the "kid" is automatically included in the JsonWebToken whenever it is present in the signing credentials. However, the JWT specification does not require the "kid" to be included, so there are scenarios where it may not be needed.

How: Implement a flag in the JsonWebTokenHandler that allows users to choose whether or not to include the "kid" in the generated JWT.

@pmaytak
Copy link
Contributor

pmaytak commented Nov 5, 2024

@sruke @msbw2 Should this be closed or is there more work to do?

@msbw2
Copy link
Contributor

msbw2 commented Nov 5, 2024

@sruke @msbw2 Should this be closed or is there more work to do?

It should have auto-resolved when the PR merged, right?

@pmaytak pmaytak linked a pull request Nov 5, 2024 that will close this issue
@pmaytak
Copy link
Contributor

pmaytak commented Nov 5, 2024

@pmaytak pmaytak closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement The issue is a new feature
Projects
None yet
3 participants