Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark config #2468

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Update benchmark config #2468

merged 3 commits into from
Jan 30, 2024

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented Jan 30, 2024

Fixes #2472

  • Update benchmarks config to match SAL.
  • Use out-of-process BDN toolchain instead of in-process one.
  • Move the configuration from class attributes into BenchmarkConfig to reduce code duplication.
  • Add a debug flag to allow debugging into benchmarks.
  • Enable EtwProfiler (should be commented out for prod).

@pmaytak pmaytak marked this pull request as ready for review January 30, 2024 18:49
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great thanks @pmaytak :shipit:

@pmaytak pmaytak merged commit 722b3ac into dev Jan 30, 2024
5 checks passed
@pmaytak pmaytak deleted the pmaytak/benchmark-config branch January 30, 2024 23:47
@jennyf19
Copy link
Collaborator

jennyf19 commented Feb 3, 2024

included in 7.3.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup BenchmarkDotNet config
3 participants