Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample(s) for OIDC #389

Open
vermegi opened this issue Jan 10, 2024 · 1 comment
Open

Add sample(s) for OIDC #389

vermegi opened this issue Jan 10, 2024 · 1 comment

Comments

@vermegi
Copy link
Member

vermegi commented Jan 10, 2024

All samples currently use publish profile both in this repo and the samples repo at https://github.com/Azure/actions-workflow-samples/tree/master/AppService.

There is one piece of sample code on how to use a service principal here https://github.com/Azure/webapps-deploy?tab=readme-ov-file#sample-workflow-to-build-and-deploy-a-nodejs-app-to-containerized-webapp-using-azure-service-principal

However using a service principal is not the recommended approach anymore for the azure-login command, the recommended approach is through OIDC: https://github.com/Azure/login?tab=readme-ov-file#login-with-openid-connect-oidc-recommended

Hence we should add samples that use this approach.

Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant