Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit messages containing emoji and multibytes cause zipdeploy to fail #336

Closed
shibayan opened this issue May 4, 2023 · 6 comments
Closed

Commit messages containing emoji and multibytes cause zipdeploy to fail #336

shibayan opened this issue May 4, 2023 · 6 comments
Assignees
@sgollapudi77
Labels
bug Something isn't working idle

Comments

@shibayan
Copy link

shibayan commented May 4, 2023

#288 fixed the maximum length of commit messages, but the fix was found to be incomplete for multibyte characters such as emoji.

URL encoding of multibyte strings increases a single character by a factor of 9 or more.

image

image

The correct implementation should perform trimming on the string after URL encoding.
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label May 18, 2023
@shpraka shpraka added backlog Planned for future and removed need-to-triage idle labels May 22, 2023
@sgollapudi77 sgollapudi77 added the enhancement New feature or request label Jul 12, 2023
@surenderssm surenderssm added bug Something isn't working and removed enhancement New feature or request backlog Planned for future labels Aug 1, 2023
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Aug 15, 2023
@shibayan
Copy link
Author

Push

@github-actions github-actions bot removed the idle label Aug 15, 2023
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Aug 29, 2023
@shibayan
Copy link
Author

Bump

@shibayan shibayan mentioned this issue Apr 22, 2024
Merged
@shibayan
Copy link
Author

We believe this has been resolved because an update on the Kudu side has increased the upper limit of acceptable query strings to 8KB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgollapudi77 sgollapudi77

Labels
bug Something isn't working idle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shibayan @surenderssm @shpraka @sgollapudi77